fix filename* parsing #3768
Merged
fix filename* parsing #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhafraDev
commented
Oct 24, 2024
| headerValue[3] !== 0x2d || // - | ||
| headerValue[4] !== 0x38 // 8 | ||
| ) { | ||
| throw parsingError('unknown encoding, expected utf-8\'\'') |
There was a problem hiding this comment.
I have no idea if utf-8 is the only accepted value here. Could not find references to other encodings in the RFC.
metcoder95
approved these changes
Oct 25, 2024
|
I may have forgotten to commit the tests... |
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3760
also fixes a case where we were too strict by disallowing spaces after
filenameandfilename*parameters. The RFC uses examples with spaces (filename*= UTF-8''%e2%82%ac%20rates)it also adds a cause to errors that gives a little more information rather than the bland "failed to parse form-data!" one