http2: extract listenHandlers and one bugfix #3722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
commented
Oct 12, 2024
| function onHttp2SessionGoAway (errorCode) { | ||
| // We cannot recover, so best to close the session and the socket | ||
| const err = this[kError] || new SocketError(`HTTP/2: "GOAWAY" frame received with code ${code}`, util.getSocketInfo(this)) | ||
| const err = this[kError] || new SocketError(`HTTP/2: "GOAWAY" frame received with code ${errorCode}`, util.getSocketInfo(this[kSocket])) |
There was a problem hiding this comment.
here we have a Http2Session, so we have to pass this[kSocket] to getSocketInfo
Uzlopak
commented
Oct 12, 2024
| closed = true | ||
| }) | ||
| socket[kClosed] = false | ||
| socket.on('close', onSocketClose) |
There was a problem hiding this comment.
I guess there is a reason to use nodes own event handler and not undicis one?
There was a problem hiding this comment.
Not on top of my mind, feel free to change it to the undici's one 👍
metcoder95
approved these changes
Oct 13, 2024
| closed = true | ||
| }) | ||
| socket[kClosed] = false | ||
| socket.on('close', onSocketClose) |
There was a problem hiding this comment.
Not on top of my mind, feel free to change it to the undici's one 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.