test: less flaky timers acceptance test, rework fast timer tests to pass them faster #3656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
force-pushed
the
less-flaky-fast-timers-test
branch
from
89fa4e9 to
570a18c
Compare
metcoder95
approved these changes
Oct 1, 2024
|
Thank you! |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
…ass them faster (#3656) * test: less flaky timers acceptance test * use fake timers * tick 10 * one tick --------- Co-authored-by: Carlos Fuentes <[email protected]> (cherry picked from commit 5308d29)
Uzlopak
added a commit
that referenced
this pull request
Oct 4, 2024
…ass them faster (#3656) (#3679) * test: less flaky timers acceptance test * use fake timers * tick 10 * one tick --------- Co-authored-by: Carlos Fuentes <[email protected]> (cherry picked from commit 5308d29) Co-authored-by: Aras Abbasi <[email protected]>
flakey5
pushed a commit
to flakey5/undici
that referenced
this pull request
Oct 8, 2024
…ass them faster (nodejs#3656) * test: less flaky timers acceptance test * use fake timers * tick 10 * one tick --------- Co-authored-by: Carlos Fuentes <[email protected]>
Merged
Closed
This was referenced Mar 27, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using sinon fake timers to run the tests faster