Skip to content

feat: check maxHeadersSize on client instantiation and not on Parser instantion #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2024
Merged

feat: check maxHeadersSize on client instantiation and not on Parser instantion #3654

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fce688
fix: check maxHeadersSize on client instantiation and not on Parser i…
Uzlopak Sep 30, 2024
998f885
ensure that http.maxHeadersize is valid
Uzlopak Oct 3, 2024
6b30664
fail early, fail fast
Uzlopak Oct 3, 2024
299f59c
Merge branch 'main' into fix-3653
metcoder95 Oct 4, 2024
d2a1290
fix
Uzlopak Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/dispatcher/client-h1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,6 @@ class Parser {
* @param {*} llhttp
*/
constructor (client, socket, { exports }) {
assert(Number.isFinite(client[kMaxHeadersSize]) && client[kMaxHeadersSize] > 0)

this.llhttp = exports
this.ptr = this.llhttp.llhttp_alloc(constants.TYPE.RESPONSE)
this.client = client
Expand Down
2 changes: 1 addition & 1 deletion lib/dispatcher/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class Client extends DispatcherBase {
throw new InvalidArgumentError('unsupported maxKeepAliveTimeout, use keepAliveMaxTimeout instead')
}

if (maxHeaderSize != null && !Number.isFinite(maxHeaderSize)) {
if (maxHeaderSize != null && (!Number.isInteger(maxHeaderSize) || maxHeaderSize < 1)) {
throw new InvalidArgumentError('invalid maxHeaderSize')
}

Expand Down
40 changes: 40 additions & 0 deletions test/node-test/client-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,46 @@ test('invalid options throws', (t, done) => {
assert.strictEqual(err.message, 'invalid maxHeaderSize')
}

try {
new Client(new URL('http://localhost:200'), { // eslint-disable-line
maxHeaderSize: 0
})
assert.ok(0)
} catch (err) {
assert.ok(err instanceof errors.InvalidArgumentError)
assert.strictEqual(err.message, 'invalid maxHeaderSize')
}

try {
new Client(new URL('http://localhost:200'), { // eslint-disable-line
maxHeaderSize: 0
})
assert.ok(0)
} catch (err) {
assert.ok(err instanceof errors.InvalidArgumentError)
assert.strictEqual(err.message, 'invalid maxHeaderSize')
}

try {
new Client(new URL('http://localhost:200'), { // eslint-disable-line
maxHeaderSize: -10
})
assert.ok(0)
} catch (err) {
assert.ok(err instanceof errors.InvalidArgumentError)
assert.strictEqual(err.message, 'invalid maxHeaderSize')
}

try {
new Client(new URL('http://localhost:200'), { // eslint-disable-line
maxHeaderSize: 1.5
})
assert.ok(0)
} catch (err) {
assert.ok(err instanceof errors.InvalidArgumentError)
assert.strictEqual(err.message, 'invalid maxHeaderSize')
}

try {
new Client(1) // eslint-disable-line
assert.ok(0)
Expand Down
Loading