fix: run asserts first if possible #3541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ronag
approved these changes
Sep 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
(cherry picked from commit 3faf140)
Uzlopak
added a commit
that referenced
this pull request
Oct 4, 2024
(cherry picked from commit 3faf140) Co-authored-by: Aras Abbasi <[email protected]>
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR tries to run various asserts before instantiating variables. also use assert instead of assert.strictEqual because passing boolean values is cheaper than passing primitive and non-primitive values to the assert.strictEqual function.