Skip to content

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Jul 10, 2024

  • docs: remove documentation
  • chore: remove interceptor api
  • chore: drop maxRedirections in pro of redirect interceptor

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@mcollina
Copy link
Member

CI is not happy

@metcoder95
Copy link
Member Author

@mcollina please have a look

@mcollina mcollina added the semver-major Features or fixes that will be included in the next semver major release label Jul 12, 2024
this[kOptions].interceptors = options.interceptors
? { ...options.interceptors }
: undefined
this[kMaxRedirections] = maxRedirections
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you throw a dedicated error if maxRedirections or interceptors are specified?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 1a6ab5f into main Jul 12, 2024
@metcoder95 metcoder95 deleted the chore/drop_interceptors branch July 12, 2024 21:52
@metcoder95 metcoder95 mentioned this pull request Jul 12, 2024
Closed
6 tasks
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-major Features or fixes that will be included in the next semver major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants