-
-
Couldn't load subscription status.
- Fork 672
feat: add dns cache #3349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dns cache #3349
Conversation
Co-authored-by: Carlos Fuentes <[email protected]>
Co-authored-by: Carlos Fuentes <[email protected]>
Co-authored-by: Carlos Fuentes <[email protected]>
|
I need help with fixing test on mac os (works on windows and linux) Test: on mac os this test fails with: on windows and linux this test resolves correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary. Already possible:
import CacheableLookup from 'cacheable-lookup';
const cacheable = new CacheableLookup(opts)
const agent = new Agent({
connect: { lookup: cacheable.lookup }
})|
Mentioning reviewers from orginal pr @mcollina @ShogunPanda @metcoder95 @KhafraDev , should I continue or close this pr ? |
|
As ronag mentioned it's already possible to use cacheable-lookup |
|
The only reason I could see for adding it is if we wanted to enable it by default, but we're probably better off just documenting it |
|
Examples |
This relates to...
#2552
Rationale
This is version of dns cache with resolved merge conflicts and tests migrated to
node:test, most of the work is done by @antoinegomezChanges
Features
Bug Fixes
Breaking Changes and Deprecations
Status