Skip to content

websocket server only needs to reply with a single subprotocol #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2024
Merged

websocket server only needs to reply with a single subprotocol #2845

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
818838d
websocket server only needs to reply with a single subprotocol
KhafraDev Feb 25, 2024
c154a63
fixup
KhafraDev Feb 25, 2024
69f3032
fixup
KhafraDev Feb 25, 2024
b5922fc
fixup
KhafraDev Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/web/websocket/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,6 @@ function establishWebSocketConnection (url, protocols, ws, onEstablish, options)
failWebsocketConnection(ws, 'Protocol was not set in the opening handshake.')
return
}
} else if (request.headersList.contains('sec-websocket-protocol', true)) {
// If the server did not send a Sec-WebSocket-Protocol header but the client did,
// fail the connection.
failWebsocketConnection(ws, 'Client sent a Sec-WebSocket-Protocol header but did not receive one from the server.')
return
}

response.socket.on('data', onSocketData)
Expand Down