refactor: avoid http2 dynamic dispatch in socket handlers #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps towards more clean separation between h1 and h2. Refs: #2816
ronag
force-pushed
the
separate-http2
branch
from
542ed6f to
275ce77
Compare
7 tasks
ronag
force-pushed
the
separate-http2
branch
2 times, most recently
from
46b3a8f to
b508db1
Compare
ronag
commented
Feb 25, 2024
| return | ||
| // TODO (fix): Why does this not return the value | ||
| // from writeH2. | ||
| writeH2(client, request) |
There was a problem hiding this comment.
@metcoder95 This is confusing to me. Seems to have been broken for a while.
There was a problem hiding this comment.
Yeah, it seems its kind of flaky there; once wrap with the interceptors I'll jump right away into H2
ronag
force-pushed
the
separate-http2
branch
from
8c9a737 to
b23d1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps towards more clean separation between h1 and h2.
Refs: #2816
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status