Skip to content

test: improve cookie tests #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024
Merged

test: improve cookie tests #2693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/cookie/cookies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ test('Cookie Name Validation', () => {
maxAge: 3
})
},
Error
new Error('Invalid cookie name')
)
})
})
Expand Down Expand Up @@ -116,7 +116,7 @@ test('Cookie Value Validation', () => {
}
)
},
Error,
new Error('Invalid header value'),
"RFC2616 cookie 'Space'"
)
})
Expand All @@ -128,7 +128,7 @@ test('Cookie Value Validation', () => {
value: 'United Kingdom'
})
},
Error,
new Error('Invalid header value'),
"RFC2616 cookie 'location' cannot contain character ' '"
)
})
Expand All @@ -147,7 +147,7 @@ test('Cookie Path Validation', () => {
maxAge: 3
})
},
Error,
new Error('Invalid cookie path'),
path + ": Invalid cookie path char ';'"
)
})
Expand All @@ -167,7 +167,7 @@ test('Cookie Domain Validation', () => {
maxAge: 3
})
},
Error,
new Error('Invalid cookie domain'),
'Invalid first/last char in cookie domain: ' + domain
)
})
Expand Down