Skip to content

Conversation

@sosukesuzuki
Copy link
Contributor

This relates to...

Closes #2486

Rationale

Tests of #2486 are failed for Node.js v21 matrix. The difference seems to have occurred because the row of console.table is now aligned to the left ( nodejs/node#50135 ).

So this PR uses left aligned tables for testing when running on node v21 and above.

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@sosukesuzuki sosukesuzuki marked this pull request as ready for review December 31, 2023 10:33
@dominykas
Copy link
Member

dominykas commented Jan 2, 2024

Please consider unpinning the version of this action (see #2434 for reasoning).

@metcoder95 metcoder95 requested review from mcollina and ronag January 2, 2024 19:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (a72bab6) 84.70%.
Report is 188 commits behind head on main.

Files Patch % Lines
lib/fetch/index.js 67.29% 52 Missing ⚠️
lib/fetch/util.js 35.52% 49 Missing ⚠️
lib/handler/RetryHandler.js 74.35% 30 Missing ⚠️
lib/api/readable.js 88.88% 5 Missing ⚠️
lib/fetch/headers.js 90.19% 5 Missing ⚠️
lib/client.js 93.44% 4 Missing ⚠️
lib/compat/dispatcher-weakref.js 42.85% 4 Missing ⚠️
lib/core/util.js 95.55% 2 Missing ⚠️
lib/fetch/request.js 92.00% 2 Missing ⚠️
lib/core/request.js 98.21% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
- Coverage   85.54%   84.70%   -0.85%     
==========================================
  Files          76       80       +4     
  Lines        6858     7239     +381     
==========================================
+ Hits         5867     6132     +265     
- Misses        991     1107     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sosukesuzuki
Copy link
Contributor Author

Please consider unpinning the version of this action (see #2434 for reasoning).

@dominykas I'm new to this project and so would like to know what maintainers think.

@sosukesuzuki
Copy link
Contributor Author

@mcollina @ronag What do you think? In general, I think that keeping the version fixed makes CI more stable and safer.

@sosukesuzuki
Copy link
Contributor Author

Suppressed by #2434

@sosukesuzuki sosukesuzuki deleted the update-pkgjs-actions branch January 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants