TypeError: Cannot read properties of undefined (reading 'onError')

[CoffeeFlux]

Bug Description

Some requests made through Undici with HTTP 2 seem to result in the following:

    at Object.errorRequest (/workspace/node_modules/undici/lib/core/util.js:638:13)
    at ClientHttp2Session.onHTTP2GoAway (/workspace/node_modules/undici/lib/dispatcher/client-h2.js:245:8)
    at ClientHttp2Session.emit (node:events:517:28)
    at ClientHttp2Session.emit (node:domain:489:12)
    at Http2Session.onGoawayData (node:internal/http2/core:677:11)

Reproducible By

Unfortunately, I don't have a nice way to reproduce this locally; I've only seen it on prod. I'm trying to get a repro and if I can find one I'll update this issue. I opened this in the meantime to see if I'm doing something wrong or if the stack trace alone is helpful in fixing it.

Expected Behavior

No type error.

Logs & Screenshots

Environment

Ubuntu 20.04, Node 16, Undici 6.20.1

Additional context

[metcoder95]

If you can provide an
Minimum Reproducible Example that will be pretty useful

[CoffeeFlux]

I'm certainly trying. It's difficult when it's seemingly caused by an error case I can't identify.

[metcoder95]

I might have an idea of how; if it is in the GOAWAY frame, it might be worth it to try just the server send that frame with no request (or requests sparse in time), as I imagine this has to be with the fact of receiving the frame and no request actually being made.

(also checking this on my side)

[tsightler]

Isn't this a dupe of #3753?

[CoffeeFlux]

The error string looks a bit different but I'm happy to check. Might have come up in searches if the logs weren't a screenshot 🤣

…

On Thu, Nov 21, 2024, 07:41 tsightler ***@***.***> wrote: Isn't this a dupe of #3753 <#3753>? — Reply to this email directly, view it on GitHub <#3857 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYIODTZKCGLHZ4MS4ZKE5T2BX5JRAVCNFSM6AAAAABSFS7WUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJRGU3TKMRVGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[metcoder95]

If you can share a reproduction, that would be great; otherwise it can be a duplicate

[CoffeeFlux]

I tried downgrading to 6.20.0 to see if this is a duplicate, and it is not; the issue still occurs. Still trying to get a repro. 2024年11月21日(木) 13:31 Carlos Fuentes ***@***.***>:

…

If you can share a reproduction, that would be great; otherwise it can be a duplicate — Reply to this email directly, view it on GitHub <#3857 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYIODUDZ76IAP5VNBDAHST2BZGLLAVCNFSM6AAAAABSFS7WUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGM3TQNZRHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Ryan Lucia

[fengmk2]

I got the same TypeError

nodejs.TypeError: Cannot read properties of undefined (reading 'onError') (uncaughtException throw 1 times on pid:2600051)
at Object.errorRequest (/home/admin/application/node_modules/_undici@6.21.0@undici/lib/core/util.js:638:13)
at ClientHttp2Session.onHTTP2GoAway (/home/admin/application/node_modules/_undici@6.21.0@undici/lib/dispatcher/client-h2.js:245:8)
at ClientHttp2Session.emit (node:events:518:28)
at Http2Session.onGoawayData (node:internal/http2/core:676:11)
at Http2Session.callbackTrampoline (node:internal/async_hooks:130:17)

the queue request is undefined

[metcoder95]

Closed by #3875