Skip to content

feat: add eol page #7990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
02db91b
feat: add eol page
bmuenzenmeyer Jul 16, 2025
113334f
Update Modal.tsx
ovflowd Jul 21, 2025
6bc1393
expand and do not reuse i18n keys
bmuenzenmeyer Jul 22, 2025
967676d
add one more i18n key
bmuenzenmeyer Jul 22, 2025
5cd1b33
add footer to article layout
bmuenzenmeyer Jul 22, 2025
d2b7826
Update apps/site/components/EOL/Table.tsx
bmuenzenmeyer Jul 22, 2025
b294b44
cleanup unused classnames
bmuenzenmeyer Jul 22, 2025
4204159
simplify Table
bmuenzenmeyer Jul 22, 2025
2cadb0c
normalize endOfLife vs eol
bmuenzenmeyer Jul 22, 2025
55abd69
Apply suggestions from code review
bmuenzenmeyer Jul 22, 2025
1a4a53a
add back in the release schedule link
bmuenzenmeyer Jul 22, 2025
51c5fb0
small grammar / tense / capitalization changes
bmuenzenmeyer Jul 22, 2025
ea43096
Update apps/site/pages/en/eol.mdx
ovflowd Jul 23, 2025
d94d5ce
increase gap between vulnerability chips
bmuenzenmeyer Jul 24, 2025
1dccbd5
Merge branch 'main' into eol
ovflowd Jul 25, 2025
21014bd
make all translation strings long-form
bmuenzenmeyer Jul 28, 2025
ff6ddec
document translation key retrieval
bmuenzenmeyer Jul 28, 2025
9c68dd0
rename variable
bmuenzenmeyer Jul 28, 2025
f8cab5e
move CTAs up
bmuenzenmeyer Jul 28, 2025
2fbd30a
Merge branch 'main' into eol
ovflowd Jul 28, 2025
7babcc8
chore: button variants, and updated eol page; removed translated prev…
ovflowd Jul 28, 2025
07befbb
rename EOLModal/index per standard
bmuenzenmeyer Jul 29, 2025
594531f
rename components per docs and patterns
bmuenzenmeyer Jul 29, 2025
c4abb0e
chore: design improvements
ovflowd Jul 29, 2025
e471cb0
chore: tiny mobile improvement
ovflowd Jul 29, 2025
6b7bde7
chore: apply suggestions
ovflowd Jul 29, 2025
2a748fd
chore: apply text suggestions
ovflowd Jul 29, 2025
e0f7c44
chore: balance the buttons
ovflowd Jul 29, 2025
5ab2cbb
fix a11y issue on mdx rendering
bmuenzenmeyer Jul 29, 2025
26f5b81
chore: make it rain tm
ovflowd Jul 29, 2025
16f5992
Update vulnerabilities.mjs
avivkeller Jul 29, 2025
ccbba0f
apply aviv"s suggestions - manually added as the redirect also needed…
bmuenzenmeyer Jul 30, 2025
40df1ab
types and constants cleanup
bmuenzenmeyer Jul 30, 2025
f424d53
fix import
bmuenzenmeyer Jul 30, 2025
7724afb
more types cleanup
bmuenzenmeyer Jul 30, 2025
669d21d
one final type lint
bmuenzenmeyer Jul 30, 2025
04e4f5c
Merge branch 'main' into eol
bmuenzenmeyer Aug 1, 2025
89e5c92
move link below buttons
bmuenzenmeyer Aug 1, 2025
748e116
move URL to constants
bmuenzenmeyer Aug 2, 2025
9fe21cc
rename variable
bmuenzenmeyer Aug 2, 2025
4836bef
tighten up UnknownSeverity types
bmuenzenmeyer Aug 2, 2025
c147efc
format after refactor
bmuenzenmeyer Aug 2, 2025
847897b
memoize calls
bmuenzenmeyer Aug 2, 2025
d61bd30
simplify translation call
bmuenzenmeyer Aug 2, 2025
1a522c8
apply suggestion
bmuenzenmeyer Aug 2, 2025
dd10604
apply linter
bmuenzenmeyer Aug 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/site/app/[locale]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ const getPage: FC<DynamicParams> = async props => {
// within a server-side context
return (
<MatterProvider {...sharedContext}>
<WithLayout layout={frontmatter.layout}>{content}</WithLayout>
<WithLayout layout={frontmatter.layout} modal={frontmatter.modal}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this approach of modal metadata to be injected at layout-level, it implies you cannnot have different sort of modals per page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even less making it part of the frontmatter, which is even worse IMO.

{content}
</WithLayout>
</MatterProvider>
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,19 @@ import type { FC } from 'react';
import { use } from 'react';

import LinkWithArrow from '#site/components/LinkWithArrow';
import { ReleaseModalContext } from '#site/providers/releaseModalProvider';
import type { NodeRelease } from '#site/types';
import { ModalContext } from '#site/providers/modalProvider';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context's should be imported from a hook. Like useModalContext

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these should be explicitly defined as client-side hooks, so that if imported from server it fails.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous implementation, a "useReleaseModalContext" hook wasn't in use, this follows that principle


type DetailsButtonProps = {
versionData: NodeRelease;
data: unknown;
};

const DetailsButton: FC<DetailsButtonProps> = ({ versionData }) => {
const DetailsButton: FC<DetailsButtonProps> = ({ data }) => {
const t = useTranslations('components.downloadReleasesTable');

const { openModal } = use(ReleaseModalContext);
const { openModal } = use(ModalContext);

return (
<LinkWithArrow
className="cursor-pointer"
onClick={() => openModal(versionData)}
>
<LinkWithArrow className="cursor-pointer" onClick={() => openModal(data)}>
{t('details')}
</LinkWithArrow>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const DownloadReleasesTable: FC = () => {
</Badge>
</td>
<td className="download-table-last">
<DetailsButton versionData={release} />
<DetailsButton data={release} />
</td>
</tr>
))}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ const ReleaseCodeBox: FC = () => {
size="small"
>
{t.rich('layouts.download.codeBox.unsupportedVersionWarning', {
link: text => <Link href="/about/previous-releases/">{text}</Link>,
link: text => <Link href="/eol">{text}</Link>,
})}
</AlertBox>
)}
Expand Down
21 changes: 5 additions & 16 deletions apps/site/components/Downloads/ReleaseModal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,11 @@ import type { FC } from 'react';
import { MinorReleasesTable } from '#site/components/Downloads/MinorReleasesTable';
import { ReleaseOverview } from '#site/components/Downloads/ReleaseOverview';
import Link from '#site/components/Link';
import type { ModalProps } from '#site/providers/modalProvider';
import type { NodeRelease } from '#site/types';

type ReleaseModalProps = {
isOpen: boolean;
closeModal: () => void;
release: NodeRelease;
};

const ReleaseModal: FC<ReleaseModalProps> = ({
isOpen,
closeModal,
release,
}) => {
const ReleaseModal: FC<ModalProps> = ({ open, closeModal, data }) => {
const release = data as NodeRelease;
const t = useTranslations();

const modalHeadingKey = release.codename
Expand All @@ -31,7 +23,7 @@ const ReleaseModal: FC<ReleaseModalProps> = ({
});

return (
<Modal open={isOpen} onOpenChange={closeModal}>
<Modal open={open} onOpenChange={closeModal}>
{release.status === 'End-of-life' && (
<div className="mb-4">
<AlertBox
Expand All @@ -41,10 +33,7 @@ const ReleaseModal: FC<ReleaseModalProps> = ({
>
{t.rich('components.releaseModal.unsupportedVersionWarning', {
link: text => (
<Link
onClick={closeModal}
href="/about/previous-releases#release-schedule"
>
<Link onClick={closeModal} href="/eol">
{text}
</Link>
),
Expand Down
18 changes: 18 additions & 0 deletions apps/site/components/EOL/Alert.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import AlertBox from '@node-core/ui-components/Common/AlertBox';
import { useTranslations } from 'next-intl';

import Link from '#site/components/Link';

const EOLAlert = () => {
const t = useTranslations('components.endOfLife');
return (
<AlertBox level="warning">
{t('intro')}{' '}
<Link href="/eol">
OpenJS Ecosystem Sustainability Program {t('partner')} HeroDevs
</Link>
</AlertBox>
);
};

export default EOLAlert;
156 changes: 156 additions & 0 deletions apps/site/components/EOL/Modal.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
import { Modal, Title, Content } from '@node-core/ui-components/Common/Modal';
import classNames from 'classnames';
import { useTranslations } from 'next-intl';
import type { FC } from 'react';

import VulnerabilityChip from '#site/components/EOL/VulnerabilityChips/Chip';
import LinkWithArrow from '#site/components/LinkWithArrow';
import type { ModalProps } from '#site/providers/modalProvider';
import type { NodeRelease } from '#site/types';
import type { Vulnerability } from '#site/types/vulnerabilities';

import { SEVERITY_ORDER } from './VulnerabilityChips';

type EOLModalData = {
release: NodeRelease;
vulnerabilities: Array<Vulnerability>;
};

type KnownVulnerability = Vulnerability & {
severity: (typeof SEVERITY_ORDER)[number];
};

const VulnerabilitiesTable: FC<{
vulnerabilities: Array<Vulnerability>;
maxWidth?: string;
}> = ({ vulnerabilities, maxWidth = 'max-w-2xs' }) => {
const t = useTranslations('components.eolModal');

return (
<table className="w-full">
<thead>
<tr>
<th>{t('table.cves')}</th>
<th>{t('table.severity')}</th>
<th>{t('table.overview')}</th>
<th>{t('table.details')}</th>
</tr>
</thead>
<tbody>
{vulnerabilities.map((vuln, i) => (
<tr key={i}>
<td>
{vuln.cve.length
? vuln.cve.map(cveId => (
<div key={cveId}>
<LinkWithArrow
href={`https://www.cve.org/CVERecord?id=${cveId}`}
target="_blank"
rel="noopener noreferrer"
>
{cveId}
</LinkWithArrow>
</div>
))
: '-'}
</td>
<td>
<VulnerabilityChip severity={vuln.severity} />
</td>
<td className={classNames(maxWidth, 'truncate')}>
{vuln.description || vuln.overview || '-'}
</td>
<td>
{vuln.ref ? (
<LinkWithArrow
href={vuln.ref}
target="_blank"
rel="noopener noreferrer"
>
{t('blogLinkText')}
</LinkWithArrow>
) : (
'—'
)}
</td>
</tr>
))}
</tbody>
</table>
);
};

const UnknownSeveritySection: FC<{
vulnerabilities: Array<Vulnerability>;
hasKnownVulns: boolean;
}> = ({ vulnerabilities, hasKnownVulns }) => {
const t = useTranslations('components.eolModal');

if (!vulnerabilities.length) {
return null;
}

return (
<details open={!hasKnownVulns}>
<summary className="cursor-pointer font-semibold">
{t('showUnknownSeverities')} ({vulnerabilities.length})
</summary>
<div className="mt-4">
<VulnerabilitiesTable
vulnerabilities={vulnerabilities}
maxWidth={'max-w-3xs'}
/>
</div>
</details>
);
};

const EOLModal: FC<ModalProps> = ({ open, closeModal, data }) => {
const { release, vulnerabilities } = data as EOLModalData;
const t = useTranslations('components.eolModal');

const modalHeading = t(release.codename ? 'title' : 'titleWithoutCodename', {
version: release.major,
codename: release.codename ?? '',
});

const [knownVulns, unknownVulns] = vulnerabilities.reduce(
(acc, vuln) => {
acc[vuln.severity === 'unknown' ? 1 : 0].push(vuln as KnownVulnerability);
return acc;
},
[[], []] as [Array<KnownVulnerability>, Array<Vulnerability>]
);

knownVulns.sort(
(a, b) =>
SEVERITY_ORDER.indexOf(a.severity) - SEVERITY_ORDER.indexOf(b.severity)
);

const hasKnownVulns = knownVulns.length > 0;
const hasAnyVulns = hasKnownVulns || unknownVulns.length > 0;

return (
<Modal open={open} onOpenChange={closeModal}>
<Title>{modalHeading}</Title>
<Content>
{vulnerabilities.length > 0 && (
<p className="m-1">
{t('vulnerabilitiesMessage', { count: vulnerabilities.length })}
</p>
)}

{hasKnownVulns && <VulnerabilitiesTable vulnerabilities={knownVulns} />}

<UnknownSeveritySection
vulnerabilities={unknownVulns}
hasKnownVulns={hasKnownVulns}
/>

{!hasAnyVulns && <p className="m-1">{t('noVulnerabilitiesMessage')}</p>}
</Content>
</Modal>
);
};

export default EOLModal;
62 changes: 62 additions & 0 deletions apps/site/components/EOL/Table.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
import { getTranslations } from 'next-intl/server';
import type { FC } from 'react';

import FormattedTime from '#site/components/Common/FormattedTime';
import DetailsButton from '#site/components/Downloads/DownloadReleasesTable/DetailsButton';
import provideReleaseData from '#site/next-data/providers/releaseData';
import provideVulnerabilities from '#site/next-data/providers/vulnerabilities';

import VulnerabilityChips from './VulnerabilityChips';

const EOLTable: FC = async () => {
const releaseData = provideReleaseData();
const vulnerabilities = await provideVulnerabilities();
const EOLReleases = releaseData.filter(
release => release.status === 'End-of-life'
);

const t = await getTranslations();

return (
<table id="tbVulnerabilities" className="download-table full-width">
<thead>
<tr>
<th>
{t('components.eolTable.version')} (
{t('components.eolTable.codename')})
</th>
<th>{t('components.eolTable.lastUpdated')}</th>
<th>{t('components.eolTable.vulnerabilities')}</th>
<th>{t('components.eolTable.details')}</th>
</tr>
</thead>
<tbody>
{EOLReleases.map(release => (
<tr key={release.major}>
<td data-label="Version">
v{release.major} {release.codename ? `(${release.codename})` : ''}
</td>
<td data-label="Date">
<FormattedTime date={release.releaseDate} />
</td>
<td>
<VulnerabilityChips
vulnerabilities={vulnerabilities[release.major]}
/>
</td>
<td className="download-table-last">
<DetailsButton
data={{
release: release,
vulnerabilities: vulnerabilities[release.major],
}}
/>
</td>
</tr>
))}
</tbody>
</table>
);
};

export default EOLTable;
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
@reference "../../../../styles/index.css";

.chipCount {
@apply mr-1
rounded-sm
bg-gray-800/20
px-1.5;
}
36 changes: 36 additions & 0 deletions apps/site/components/EOL/VulnerabilityChips/Chip/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import Badge from '@node-core/ui-components/Common/Badge';
import { useTranslations } from 'next-intl';
import type { FC } from 'react';

import styles from './index.module.css';

export const SEVERITY_ORDER = ['critical', 'high', 'medium', 'low'] as const;

const SEVERITY_KIND_MAP = {
unknown: 'neutral',
low: 'default',
medium: 'info',
high: 'warning',
critical: 'error',
} as const;

type VulnerabilityChipProps = {
severity: keyof typeof SEVERITY_KIND_MAP;
count?: number;
};

const VulnerabilityChip: FC<VulnerabilityChipProps> = ({
severity,
count = 0,
}) => {
const t = useTranslations('components.endOfLife');

return (
<Badge size="small" kind={SEVERITY_KIND_MAP[severity]} className="mr-0.5">
{count > 0 ? <span className={styles.chipCount}>{count}</span> : null}
{t(`severity.${severity}`)}
</Badge>
);
};

export default VulnerabilityChip;
Loading
Loading