events: don't call resume after close (fix readline regression) #60548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60507
Regression from: #58283
Since #58283, readline is not compatible with
EventEmitter.on(and readline own async iterator)It throws on attempting to
.resumethe stream after it was closed, which was whatEventEmitter.onwas doingDraft because I need to add tests
Actual changes are ready though, PTAL
Another option is to make
.resumea noop in closed state instead of throwing