stream: add bytes() method to stream/consumers #60426
Conversation
|
Review requested:
|
nodejs-github-bot
added
needs-ci
H4ad
added
the
semver-minor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60426 +/- ##
==========================================
- Coverage 88.58% 88.56% -0.02%
==========================================
Files 704 704
Lines 207823 207867 +44
Branches 40049 40052 +3
==========================================
Hits 184101 184101
- Misses 15772 15816 +44
Partials 7950 7950
🚀 New features to boost your workflow:
|
wantaekchoi
force-pushed
the
add-stream-consumers-bytes
branch
2 times, most recently
from
3887f53 to
4117fc0
Compare
- Add bytes() method to get Uint8Array from streams - Add tests for bytes() method in PassThrough and ObjectMode scenarios - Update documentation Fixes: nodejs#59542
wantaekchoi
force-pushed
the
add-stream-consumers-bytes
branch
from
4117fc0 to
b6a5a18
Compare
Co-authored-by: René <[email protected]>
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
This LGTM but I'm not explicitly approving it. I don't know why we really need this when user's could do new Uint8Array(await arrayBuffer(stream)); themselves (or rather any conversion from the raw ArrayBuffer).
|
Looking at the issue, I see this is meant to align us with the new I'm okay with that then :) nice work! |
| import { bytes } from 'node:stream/consumers'; | ||
| import { Readable } from 'node:stream'; | ||
|
|
||
| const dataBuffer = Buffer.from('hello world from consumers!'); |
There was a problem hiding this comment.
It looks like lint-md is complaining about this line – you'll need to add an explicit Buffer import from node:buffer to your examples to make it happy!
There was a problem hiding this comment.
You're right, thanks for catching that! I've added explicit imports
for Buffer from 'node:buffer' in both the ESM and CommonJS examples.
Local lint verification confirms it passes now.
5 participants
stream: add bytes() method to stream/consumers
Add a
bytes()method to thestream/consumersmodule that returns a Uint8Array, providing a convenient way to consume streams as typed arrays.Fixes: #59542