Skip to content

v8: add cpu profile #59807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

v8: add cpu profile #59807

wants to merge 1 commit into from
+132 −0

Conversation

theanarkh
Copy link
Contributor

Refs: #59428, #59429

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 8, 2025
@theanarkh theanarkh force-pushed the v8_add_cpu_profile_api branch from 7214ba0 to 7dcb480 Compare September 8, 2025 13:50
@theanarkh theanarkh added v8 module Issues and PRs related to the "v8" subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 8, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.29%. Comparing base (861d624) to head (ff0cced).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/node_v8.cc 75.00% 2 Missing and 5 partials ⚠️
lib/v8.js 94.11% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59807      +/-   ##
==========================================
+ Coverage   88.26%   88.29%   +0.03%     
==========================================
  Files         701      702       +1     
  Lines      206774   206940     +166     
  Branches    39778    39807      +29     
==========================================
+ Hits       182514   182726     +212     
+ Misses      16298    16220      -78     
- Partials     7962     7994      +32
Files with missing lines Coverage Δ
src/node_v8.h 40.00% <ø> (ø)
lib/v8.js 99.02% <94.11%> (-0.35%) ⬇️
src/node_v8.cc 80.63% <75.00%> (-0.26%) ⬇️

... and 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

juanarbol
juanarbol approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM!

I wasn't expecting the serializer to land Node.js! <3

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69144/

@theanarkh theanarkh force-pushed the v8_add_cpu_profile_api branch 2 times, most recently from b41c98b to d50d6e9 Compare September 10, 2025 18:01
jasnell
jasnell reviewed Sep 13, 2025
View reviewed changes
jasnell
jasnell reviewed Sep 13, 2025
View reviewed changes
@theanarkh theanarkh force-pushed the v8_add_cpu_profile_api branch from d50d6e9 to ff0cced Compare September 14, 2025 14:25
jasnell
jasnell reviewed Sep 15, 2025
View reviewed changes
test/parallel/test-v8-cpu-profile.js
const handle = v8.startCpuProfile();
const profile = handle.stop();
assert.ok(typeof profile === 'string');
assert.ok(profile.length > 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: a test that exercises the using syntax would be ideal also

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69237/

@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. v8 module Issues and PRs related to the "v8" subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theanarkh @nodejs-github-bot @jasnell @juanarbol