bootstrap: initialize http proxy after user module loader setup #58938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The externalized undici relies on the user module loader, so in the externalized build, initialization of http proxy which relies on undici needs to be deferred until after the user module loader is initialized.
nodejs-github-bot
added
needs-ci
juanarbol
approved these changes
Jul 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58938 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 640 640
Lines 188462 188476 +14
Branches 36962 36966 +4
=======================================
+ Hits 169786 169808 +22
+ Misses 11404 11385 -19
- Partials 7272 7283 +11
🚀 New features to boost your workflow:
|
targos
approved these changes
Jul 3, 2025
richardlau
approved these changes
Jul 3, 2025
github-actions
bot
removed
the
request-ci
atlowChemi
approved these changes
Jul 4, 2025
atlowChemi
added
author ready
legendecas
approved these changes
Jul 4, 2025
lpinca
approved these changes
Jul 4, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0534672 |
|
In this case what happened if a external http(s) loader is registered that need http_proxy to resolve http(s) specifier ? |
|
As long as the http/https requests happen after the bootstrap completes (for example, only in hooks, not at the top level of the loader code), that shouldn't be a problem. |
|
okay nice ! |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 8, 2025
The externalized undici relies on the user module loader, so in the externalized build, initialization of http proxy which relies on undici needs to be deferred until after the user module loader is initialized. PR-URL: #58938 Refs: #58865 Refs: #57872 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The externalized undici relies on the user module loader, so in the externalized build, initialization of http proxy which relies on undici needs to be deferred until after the user module loader is initialized.
Refs: #58865
Refs: #57872