[22.x] win,build: Fix MSVS v17.14 compilation issue on v22 #58902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
targos
approved these changes
Jun 30, 2025
lpinca
approved these changes
Jul 1, 2025
StefanStojanovic
force-pushed
the
mefi-v22-msvs-fix
branch
from
e22145e to
dd492d0
Compare
I've updated the embedder string. Sorry for the delay with the response, but I wanted to test compiling with both 17.13 and 17.12 (on my other machine), and it works on both. |
targos
approved these changes
Jul 2, 2025
marco-ippolito
approved these changes
Jul 2, 2025
marco-ippolito
changed the title
github-actions
bot
removed
the
request-ci
|
|
richardlau
approved these changes
Jul 3, 2025
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 3, 2025
Fixes: #58801 PR-URL: #58902 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in d649e9a |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 15, 2025
Fixes: #58801 PR-URL: #58902 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents updating VS 2022 to the latest version (v17.14), in the release CI. We had similar issues with few VS updates in the past too (17.10 and 17.12 IIRC.
Fixes: #58801