test_runner: correct "already mocked" error punctuation placement #58840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobJingleheimer
added
fast-track
|
Review requested:
|
|
Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve. |
pmarchini
approved these changes
Jun 26, 2025
gurgunday
approved these changes
Jun 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58840 +/- ##
==========================================
+ Coverage 90.08% 90.10% +0.02%
==========================================
Files 640 640
Lines 188446 188446
Branches 36960 36966 +6
==========================================
+ Hits 169757 169798 +41
+ Misses 11412 11359 -53
- Partials 7277 7289 +12
🚀 New features to boost your workflow:
|
Ethan-Arrowood
approved these changes
Jun 26, 2025
JakobJingleheimer
added
the
request-ci
github-actions
bot
removed
the
request-ci
tniessen
approved these changes
Jun 26, 2025
|
Sooo the rule for this is when the quoted text is a complete sentence that has its own terminal punctuation:
When it's not, it doesn't:
In both cases, there is always terminal punctuation after the quotes 🙂 EDIT: But yes, I think the more important issue is not reporting the specifier in a misleading way. |
JakobJingleheimer
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58840 ✔ Done loading data for nodejs/node/pull/58840 ----------------------------------- PR info ------------------------------------ Title test_runner: correct "already mocked" error punctuation placement (#58840) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JakobJingleheimer:testrunner/fix/already-mocked-error-message -> nodejs:main Labels fast-track, needs-ci, test_runner Commits 1 - test_runner: correct "already mocked" error punctuation placement Committers 1 - Jacob Smith <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58840 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58840 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 26 Jun 2025 10:01:34 GMT ✔ Approvals: 3 ✔ - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/58840#pullrequestreview-2961537077 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58840#pullrequestreview-2962262634 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/58840#pullrequestreview-2962468027 ℹ This PR is being fast-tracked ✘ This PR needs to wait 38 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-26T14:13:20Z: https://ci.nodejs.org/job/node-test-pull-request/67666/ - Querying data for job/node-test-pull-request/67666/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15910286689 |
|
Ugh. Could I get 1 more 👍 on the fast-track please |
lpinca
approved these changes
Jun 26, 2025
lpinca
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5b0c7db |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58840 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current message contains a period within the quotes around the specifier, making it look malformed.