build: use FILE_OFFSET_BITS=64 even on 32-bit arch #58090

RafaelGSS · 2025-04-30T20:24:26Z

Refs: #57934

nodejs-github-bot · 2025-04-30T20:24:30Z

Review requested:

@nodejs/gyp

mcollina

lgtm

nodejs-github-bot · 2025-04-30T22:33:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66520/

bnoordhuis · 2025-05-01T07:04:37Z

s/even on/esp. on/ - on 64 bits architectures the define is a no-op because off_t is already 64 bits.

nodejs-github-bot · 2025-05-01T08:38:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66523/

mhdawson

LGTM

Co-Authored-By: richardlau - Richard Lau <[email protected]>

RafaelGSS · 2025-05-06T18:37:29Z

CI was green. Landing it manually as I had to update commit title.

Co-Authored-By: richardlau - Richard Lau <[email protected]> PR-URL: #58090 Refs: #57934 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

RafaelGSS · 2025-05-06T18:39:03Z

Landed in 74c8358

Co-Authored-By: richardlau - Richard Lau <[email protected]> PR-URL: #58090 Refs: #57934 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

nodejs/node#58090

* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>

nodejs/node#58090

* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>

nodejs/node#58090

* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>

RafaelGSS requested review from mcollina, richardlau and mhdawson April 30, 2025 20:24

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 30, 2025

mcollina approved these changes Apr 30, 2025

View reviewed changes

aduh95 approved these changes Apr 30, 2025

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v20.x PRs that may need to be released in v20.x labels Apr 30, 2025

richardlau approved these changes Apr 30, 2025

View reviewed changes

richardlau added the lts-watch-v22.x PRs that may need to be released in v22.x label Apr 30, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025

anonrig approved these changes May 1, 2025

View reviewed changes

mhdawson approved these changes May 1, 2025

View reviewed changes

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

2f9406d

Co-Authored-By: richardlau - Richard Lau <[email protected]>

RafaelGSS force-pushed the use-file-offset-bits-64-by-default branch from 6132c85 to 2f9406d Compare May 4, 2025 16:34

RafaelGSS closed this May 6, 2025

github-actions bot mentioned this pull request May 20, 2025

2025-05-21, Version 24.1.0 (Current) #58406

Merged

marco-ippolito removed the lts-watch-v20.x PRs that may need to be released in v20.x label Jun 5, 2025

marco-ippolito mentioned this pull request Jun 5, 2025

v20.19.3 proposal #58588

Merged

aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Jun 10, 2025

github-actions bot mentioned this pull request Jun 10, 2025

2025-06-24, Version 22.17.0 'Jod' (LTS) #58665

Merged

codebytere added a commit to electron/electron that referenced this pull request Jun 26, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

7a3f938

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

585c65d

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

a34cc80

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

d61e58f

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

8ec83fb

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

2651893

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

feda3b9

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

a8c9d5c

nodejs/node#58090

codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025

build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

70b07bd

nodejs/node#58090

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

build: use FILE_OFFSET_BITS=64 even on 32-bit arch #58090

build: use FILE_OFFSET_BITS=64 even on 32-bit arch #58090

Uh oh!

RafaelGSS commented Apr 30, 2025

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

bnoordhuis commented May 1, 2025

Uh oh!

nodejs-github-bot commented May 1, 2025

Uh oh!

mhdawson left a comment

Uh oh!

RafaelGSS commented May 6, 2025

Uh oh!

RafaelGSS commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

build: use FILE_OFFSET_BITS=64 even on 32-bit arch #58090

build: use FILE_OFFSET_BITS=64 even on 32-bit arch #58090

Uh oh!

Conversation

RafaelGSS commented Apr 30, 2025

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

bnoordhuis commented May 1, 2025

Uh oh!

nodejs-github-bot commented May 1, 2025

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

RafaelGSS commented May 6, 2025

Uh oh!

RafaelGSS commented May 6, 2025

Uh oh!

Uh oh!