doc: fix return value of write methods #5736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefourtheye
added
doc
Contributor
|
LGTM. cc @trevnorris |
| * `offset` {Number} `0 <= offset <= buf.length - 8` | ||
| * `noAssert` {Boolean} Default: false | ||
| * Return: {Number} Numbers of bytes written | ||
| * Return: {Number} The offset plus the number of written bytes |
Contributor
There was a problem hiding this comment.
Perhaps 'offset' should be surrounded by backticks in each of these changes since it's referencing a parameter.
Member
|
LGTM. |
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 16, 2016
Fixes: https:github.com//issues/5682 PR-URL: #5736 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Member
|
Landed in 939d6ef |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Fixes: https:github.com//issues/5682 PR-URL: #5736 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Fixes: https:github.com//issues/5682 PR-URL: #5736 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Fixes: https:github.com//issues/5682 PR-URL: #5736 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
Fixes: https:github.com//issues/5682 PR-URL: #5736 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5682