Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Sep 20, 2024

Just git node wpt WebCryptoAPI.

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto web-standards Issues and PRs related to Web APIs labels Sep 20, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 20, 2024
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (d5c29ba) to head (0816051).
Report is 512 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55029      +/-   ##
==========================================
- Coverage   88.06%   88.03%   -0.04%     
==========================================
  Files         652      652              
  Lines      183546   183797     +251     
  Branches    35860    35861       +1     
==========================================
+ Hits       161648   161801     +153     
- Misses      15149    15243      +94     
- Partials     6749     6753       +4     

see 50 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2024

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2024
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0e187e4 into nodejs:main Sep 22, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 0e187e4

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55029
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55029
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@marco-ippolito marco-ippolito added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55029
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web-standards Issues and PRs related to Web APIs webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants