doc: correct typescript stdin support #54036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-ippolito
added
strip-types
Contributor
|
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
Member
Author
|
we definitely need to add this doc under some codeowner cc @nodejs/loaders |
GeoffreyBooth
approved these changes
Jul 25, 2024
Member
GeoffreyBooth
left a comment
GeoffreyBooth
left a comment
There was a problem hiding this comment.
Fine, but why would it work for eval and not STDIN? We usually treat those as equivalent.
Member
Author
It has not been implemented or tested, it has to be done, so pr welcome 😆 |
anonrig
approved these changes
Jul 25, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2cd9687 |
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
PR-URL: #54036 Fixes: #54035 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54036 Fixes: #54035 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STDIN was never meant to be supported initally, so the documentation is incorrect.
Fixes: #54035