deps: add gn build files for ncrypto #53940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jul 19, 2024
Collaborator
Collaborator
anonrig
approved these changes
Jul 25, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3de7a4c |
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
PR-URL: #53940 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #53940 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos
added
the
dont-land-on-v20.x
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
PR-URL: nodejs/node#53940 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
PR-URL: nodejs/node#53940 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
PR-URL: nodejs/node#53940 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
isheludko
reviewed
Oct 7, 2025
|
|
||
| source_set(target_name) { | ||
| forward_variables_from(invoker, "*") | ||
| public_configs = [ ":ncrypto_config" ] |
Contributor
There was a problem hiding this comment.
FYI: This line pollutes component user's cflags with this component's cflags. As a result usages of deprecated Apis in Node stopped producing compilation errors.
See the fix: v8#229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GN build files for the new ncrypto dependency.