deps: reland "Remove --harmony-rab-gsab" #53755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
[arraybuffers] initialize max byte length of empty array buffers
Without initializing the max byte length field, any empty array
buffer captured in the snapshot can make the snapshot unreproducible.
Refs: nodejs#53579
Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94754}
Refs: v8/v8@e061cf9
Original commit message:
[rab/gsab] Remove --harmony-rab-gsab (has been on by default for a while)
Bug: v8:11111
Change-Id: Ie74e7737f3e2e8730820cf00f1cbc7ae02b515af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5516580
Commit-Queue: Marja Hölttä <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Reviewed-by: Nico Hartmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#93848}
Refs: v8/v8@9ebca66
PR-URL: nodejs#53522
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Member
Author
|
cc @legendecas |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
The PR LGTM. However, the original PR CI was green: #53522 (comment). Is there anything missing from the CI? Or it could just be a flaky case. |
This comment was marked as outdated.
This comment was marked as outdated.
benjamingr
approved these changes
Jul 7, 2024
legendecas
approved these changes
Jul 7, 2024
Member
Author
I think there might be some subtle factors that affected the reproduction of that flake. For example, when I tried to debug that failure locally, either compiling the builds with symbols, or linking to an OpenSSL without overriding the preload paths would make it unreproducible. Considering that it's uninitialized memory that's making it fail, it kind of make sense since these may all affect the memory allocation behavior subtly. I guess the best we can do is to wait and see how green the CI is after this lands. |
Collaborator
Collaborator
Collaborator
VoltrexKeyva
added
the
author ready
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 307430e...1a1639d |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Original commit message:
[arraybuffers] initialize max byte length of empty array buffers
Without initializing the max byte length field, any empty array
buffer captured in the snapshot can make the snapshot unreproducible.
Refs: #53579
Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94754}
Refs: v8/v8@e061cf9
PR-URL: #53755
Fixes: #53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Original commit message:
[rab/gsab] Remove --harmony-rab-gsab (has been on by default for a while)
Bug: v8:11111
Change-Id: Ie74e7737f3e2e8730820cf00f1cbc7ae02b515af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5516580
Commit-Queue: Marja Hölttä <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Reviewed-by: Nico Hartmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#93848}
Refs: v8/v8@9ebca66
PR-URL: #53522
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53755
Fixes: #53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
Original commit message:
[arraybuffers] initialize max byte length of empty array buffers
Without initializing the max byte length field, any empty array
buffer captured in the snapshot can make the snapshot unreproducible.
Refs: #53579
Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94754}
Refs: v8/v8@e061cf9
PR-URL: #53755
Fixes: #53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
Original commit message:
[rab/gsab] Remove --harmony-rab-gsab (has been on by default for a while)
Bug: v8:11111
Change-Id: Ie74e7737f3e2e8730820cf00f1cbc7ae02b515af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5516580
Commit-Queue: Marja Hölttä <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Reviewed-by: Nico Hartmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#93848}
Refs: v8/v8@9ebca66
PR-URL: #53522
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53755
Fixes: #53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
Original commit message:
[arraybuffers] initialize max byte length of empty array buffers
Without initializing the max byte length field, any empty array
buffer captured in the snapshot can make the snapshot unreproducible.
Refs: #53579
Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94754}
Refs: v8/v8@e061cf9
PR-URL: #53755
Fixes: #53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
Original commit message:
[rab/gsab] Remove --harmony-rab-gsab (has been on by default for a while)
Bug: v8:11111
Change-Id: Ie74e7737f3e2e8730820cf00f1cbc7ae02b515af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5516580
Commit-Queue: Marja Hölttä <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Reviewed-by: Nico Hartmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#93848}
Refs: v8/v8@9ebca66
PR-URL: #53522
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53755
Fixes: #53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Jul 17, 2024
Original commit message:
[arraybuffers] initialize max byte length of empty array buffers
Without initializing the max byte length field, any empty array
buffer captured in the snapshot can make the snapshot unreproducible.
Refs: nodejs#53579
Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94754}
Refs: v8/v8@e061cf9
PR-URL: nodejs#53755
Fixes: nodejs#53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Jul 17, 2024
Original commit message:
[arraybuffers] initialize max byte length of empty array buffers
Without initializing the max byte length field, any empty array
buffer captured in the snapshot can make the snapshot unreproducible.
Refs: nodejs#53579
Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94754}
Refs: v8/v8@e061cf9
PR-URL: nodejs#53755
Fixes: nodejs#53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
Original commit message:
[arraybuffers] initialize max byte length of empty array buffers
Without initializing the max byte length field, any empty array
buffer captured in the snapshot can make the snapshot unreproducible.
Refs: nodejs#53579
Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94754}
Refs: v8/v8@e061cf9
PR-URL: nodejs#53755
Fixes: nodejs#53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
Original commit message:
[rab/gsab] Remove --harmony-rab-gsab (has been on by default for a while)
Bug: v8:11111
Change-Id: Ie74e7737f3e2e8730820cf00f1cbc7ae02b515af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5516580
Commit-Queue: Marja Hölttä <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Reviewed-by: Nico Hartmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#93848}
Refs: v8/v8@9ebca66
PR-URL: nodejs#53522
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#53755
Fixes: nodejs#53579
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit was previously reverted in 8e33f20 because it broke the snapshot reproducibility test. It should be working now together with https://chromium-review.googlesource.com/c/v8/v8/+/5662576 which is the first commit in this PR (the commit order matters).
Fixes: #53579