Skip to content

deps: c-ares: cherry-pick 64df444 #53706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

deps: c-ares: cherry-pick 64df444 #53706

wants to merge 1 commit into from

Conversation

@zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Jul 3, 2024

Backport c-ares/c-ares#802 which fixes compilation error when building for Windows with UNICODE defined.

@zcbenz
deps: c-ares: cherry-pick 64df444
b8aca0c 
Backport c-ares/c-ares#802 which fixes
compilation error when building for Windows with UNICODE defined.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2024

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 3, 2024
@zcbenz zcbenz added request-ci Add this label to start a Jenkins CI on a PR. and removed cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. labels Jul 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60018/

@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60059/

@lpinca
Copy link
Member

lpinca commented Jul 4, 2024

A new version of c-ares is already available. I think it is better to upgrade to that version instead of cherry picking this commit.

@zcbenz
Copy link
Contributor Author

zcbenz commented Jul 4, 2024

I’m good updating to the latest version instead.

@lpinca
Copy link
Member

lpinca commented Jul 4, 2024

See #53722.

@zcbenz zcbenz closed this Jul 5, 2024
@zcbenz zcbenz deleted the fix-cares-win-build branch July 5, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zcbenz @nodejs-github-bot @lpinca @jasnell @StefanStojanovic