[v20.x] Revert "crypto: make timingSafeEqual faster for Uint8Array" #53390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0f784c9 because it triggers a bug in the V8 version that Node.js 20.x uses.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
richardlau
approved these changes
Jun 8, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
What is that bug? |
Collaborator
targos
approved these changes
Jun 9, 2024
marco-ippolito
approved these changes
Jun 9, 2024
benjamingr
approved these changes
Jun 9, 2024
anonrig
approved these changes
Jun 9, 2024
panva
approved these changes
Jun 10, 2024
panva
added
the
author ready
RafaelGSS
approved these changes
Jun 10, 2024
RafaelGSS
added
commit-queue
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 12, 2024
This reverts commit 0f784c9 because it triggers a bug in the V8 version that Node.js 20.x uses. PR-URL: #53390 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Member
|
Landed in cd1415c |
Merged
susnux
added a commit
to nextcloud-libraries/nextcloud-vite-config
that referenced
this pull request
Jun 21, 2024
Ref: nodejs/node#53390 Signed-off-by: Ferdinand Thiessen <[email protected]>
backportbot bot
pushed a commit
to nextcloud-libraries/nextcloud-vite-config
that referenced
this pull request
Jun 21, 2024
Ref: nodejs/node#53390 Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added a commit
to nextcloud-libraries/nextcloud-vite-config
that referenced
this pull request
Jun 21, 2024
Ref: nodejs/node#53390 Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0f784c9 because it triggers a bug in the V8 version that Node.js 20 uses. Newer release lines are not affected by the bug in V8, hence, this revert specifically targets Node.js 20.