build: fix warning in cares under GN build #51687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
cares
lpinca
approved these changes
Feb 7, 2024
marco-ippolito
approved these changes
Feb 7, 2024
Contributor
Author
|
Can this be merged? It is currently breaking GN build. |
|
+1 It is breaking V8 Node CI. Duplicate: #51756 |
Member
|
This should be merged quickly after the security release. |
juanarbol
added
the
fast-track
Contributor
|
Fast-track has been requested by @juanarbol. Please 👍 to approve. |
Collaborator
zcbenz
force-pushed
the
cares-warning
branch
from
50f52f5 to
7a0885c
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709
zcbenz
force-pushed
the
cares-warning
branch
from
7a0885c to
c01e971
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
zcbenz
added
commit-queue-squash
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51687 ✔ Done loading data for nodejs/node/pull/51687 ----------------------------------- PR info ------------------------------------ Title build: fix warning in cares under GN build (#51687) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:cares-warning -> nodejs:main Labels cares, needs-ci, dependencies, commit-queue-squash Commits 1 - build: fix warning in cares under GN build Committers 1 - Cheng Zhao PR-URL: https://github.com/nodejs/node/pull/51687 Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Juan José Arboleda ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51687 Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Juan José Arboleda -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: fix warning in cares under GN build ℹ This PR was created on Wed, 07 Feb 2024 05:21:35 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867015435 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867295688 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/51687#pullrequestreview-1880447000 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-23T05:51:27Z: https://ci.nodejs.org/job/node-test-pull-request/57327/ - Querying data for job/node-test-pull-request/57327/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8015803850 |
zcbenz
added a commit
that referenced
this pull request
Feb 23, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Contributor
Author
|
Landed in f22802c |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: nodejs#51687 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709