v8: enable maglev on supported architectures

[kvakil]

Enable V8's new maglev compiler by default on supported architectures.
This brings modest performance improvements for short-lived workloads
like CLI programs (see the linked issue) and brings Node.js's
configuration slightly closer to Google Chrome's.

I marked this change as semver-major because Maglev can theoretically
cause performance regressions, although I haven't seen an example of
that in the (somewhat limited) benchmarking I've done.

Notable Change Summary: V8's Maglev Compiler is now enabled by
default on supported architectures (https://v8.dev/blog/maglev). Maglev
improves CPU performance for short-lived CLI programs by around 8%.

Fixes: #50690

[github-actions]

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @kvakil.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56658/

[targos]

@nodejs/python

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5751/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5751/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5751/

[targos]

Breaks ARM cross-compilation: https://ci.nodejs.org/job/node-cross-compile/46243/nodes=cross-compiler-rhel8-armv7-gcc-10-glibc-2.28/

[kvakil]

Breaks ARM cross-compilation: https://ci.nodejs.org/job/node-cross-compile/46243/nodes=cross-compiler-rhel8-armv7-gcc-10-glibc-2.28/

It looks like the failing part is:

00:34:34   ccache /opt/raspberrypi/rpi-newer-crosstools/x64-gcc-10.3.0-glibc-2.28/arm-rpi-linux-gnueabihf/bin/arm-rpi-linux-gnueabihf-g++ -march=armv7-a -o /home/iojs/build/workspace/node-cross-compile/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/backend/move-optimizer.o ../deps/v8/src/compiler/backend/move-optimizer.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_HAS_QUIC' '-DICU_NO_USER_DATA_OVERRIDE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DV8_TARGET_ARCH_ARM' '-DCAN_USE_ARMV7_INSTRUCTIONS' '-DCAN_USE_VFP3_INSTRUCTIONS' '-DCAN_USE_VFP32DREGS' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_LINUX' '-DV8_EMBEDDER_STRING="-node.19"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_ENABLE_PRIVATE_MAPPING_FORK_OPTIMIZATION' '-DOBJECT_PRINT' '-DV8_INTL_SUPPORT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS' '-DV8_USE_SIPHASH' '-DV8_SHARED_RO_HEAP' '-DV8_WIN64_UNWINDING_INFO' '-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' '-DV8_USE_ZLIB' '-DV8_ENABLE_MAGLEV' '-DV8_ENABLE_TURBOFAN' '-DV8_ENABLE_WEBASSEMBLY' '-DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS' '-DV8_ALLOCATION_FOLDING' '-DV8_ALLOCATION_SITE_TRACKING' '-DV8_ADVANCED_BIGINT_ALGORITHMS' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../deps/v8/include -I/home/iojs/build/workspace/node-cross-compile/out/Release/obj/gen/generate-bytecode-output-root -I/home/iojs/build/workspace/node-cross-compile/out/Release/obj/gen -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wno-unused-parameter -Wno-return-type -flax-vector-conversions -Wno-invalid-offsetof -fno-strict-aliasing -march=armv7-a -mfpu=vfpv3 -mfloat-abi=hard -marm -O3 -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O3 -fno-rtti -fno-exceptions -std=gnu++17 -MMD -MF /home/iojs/build/workspace/node-cross-compile/out/Release/.deps//home/iojs/build/workspace/node-cross-compile/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/backend/move-optimizer.o.d.raw   -c
00:36:31 g++: fatal error: Killed signal terminated program cc1plus

It's a little difficult to tell what got killed here, but it looks like the Makefile is running without parallelism, so I'm assuming it's the compilation of deps/v8/src/compiler/backend/move-optimizer.cc. That isn't related to Maglev, so I suspect something else.

I looked through the other CI failures and they look unrelated, except potentially the Ubuntu arm64 debug build which has several suspicious looking segfaults.

Anyway, I'm going to resume the CI job.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56668/

[RafaelGSS]

Can we have a benchmark script or something added to nodejs internal benchmark to measure the impact of this new compiler?

[kvakil]

Can we have a benchmark script or something added to nodejs internal benchmark to measure the impact of this new compiler?

Hm, that seems like a big lift. In my mind V8 is responsible for "general Javascript performance" and Node.js is responsible for "standard library performance". I'm not sure if trying to create a representative general Javascript performance benchmark in Node.js would be possible, but maybe I'm misunderstanding your request.

If you're looking for some ad-hoc benchmarking, there's some of that in the linked issue.

[merceyz]

Perhaps the benchmarks added in #50684 would do?

[kvakil]

Perhaps the benchmarks added in #50684 would do?

Yes, it's a good idea. I tried that in #50690 (comment). --version doesn't actually do enough work to tier up into Maglev.

[RafaelGSS]

Hm, that seems like a big lift. In my mind V8 is responsible for "general Javascript performance" and Node.js is responsible for "standard library performance". I'm not sure if trying to create a representative general Javascript performance benchmark in Node.js would be possible, but maybe I'm misunderstanding your request.

That works! I just wanted to check the impact of this PR even in micro-benchmarks. Just for comparison reasons.

[nodejs-github-bot]

Landed in 1a5acd0