doc: fix TestsStream parent class
#51181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
lpinca
approved these changes
Dec 16, 2023
Member
|
I understand why you added "link" in the commit message but it is a bit confusing. How about "fix |
pluris
force-pushed
the
doc/test_stream
branch
from
4fc70a7 to
0c1d19c
Compare
pluris
changed the title
TestsStreamTestsStream parent class
Contributor
Author
|
@lpinca I think the commit message you suggested is clearer. |
MoLow
approved these changes
Dec 16, 2023
aduh95
added
author ready
atlowChemi
approved these changes
Dec 17, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b931e61 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51181 Fixes: #51174 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51181 Fixes: #51174 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the problem, the link was incorrect and has been fixed.
https://nodejs.org/api/test.html#class-testsstream
node/lib/internal/test_runner/tests_stream.js
Line 10 in fa18378
Fixes: #51174