benchmark: update the number of iteration on util/inspect.js #50651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
jasnell
approved these changes
Nov 11, 2023
H4ad
approved these changes
Nov 17, 2023
H4ad
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Contributor
|
Landed in cdb6519 |
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
PR-URL: #50651 Refs: #50571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50651 Refs: #50571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare to v18.x and 22.x, in the benchmark for
util.inspect,when
objisDate, asnincreases,the difference in benchmark results gradually grows larger,
possibly also due to the influence of V8 JIT.
n = [2e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=20000 *** -21.01 % ±1.95% ±2.60% ±3.39% util/inspect.js option='none' method='Date' n=20000 *** -24.24 % ±1.64% ±2.19% ±2.86% util/inspect.js option='showHidden' method='Date' n=20000 *** -21.55 % ±1.32% ±1.76% ±2.30% n = [4e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=40000 *** -25.63 % ±1.88% ±2.50% ±3.26% util/inspect.js option='none' method='Date' n=40000 *** -29.94 % ±1.20% ±1.60% ±2.09% util/inspect.js option='showHidden' method='Date' n=40000 *** -23.07 % ±2.99% ±4.01% ±5.30% n = [6e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=60000 *** -28.01 % ±1.49% ±1.99% ±2.61% util/inspect.js option='none' method='Date' n=60000 *** -32.91 % ±1.53% ±2.05% ±2.71% util/inspect.js option='showHidden' method='Date' n=60000 *** -27.59 % ±2.30% ±3.07% ±4.01% n = [8e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=80000 *** -31.34 % ±1.55% ±2.07% ±2.70% util/inspect.js option='none' method='Date' n=80000 *** -32.49 % ±1.48% ±1.98% ±2.59% util/inspect.js option='showHidden' method='Date' n=80000 *** -28.80 % ±1.76% ±2.34% ±3.05% n = [1e5]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=100000 *** -30.87 % ±2.19% ±2.92% ±3.80% util/inspect.js option='none' method='Date' n=100000 *** -33.26 % ±1.79% ±2.39% ±3.12% util/inspect.js option='showHidden' method='Date' n=100000 *** -28.31 % ±2.07% ±2.75% ±3.58% n = [12e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=120000 *** -31.74 % ±1.84% ±2.45% ±3.21% util/inspect.js option='none' method='Date' n=120000 *** -32.62 % ±1.30% ±1.73% ±2.26% util/inspect.js option='showHidden' method='Date' n=120000 *** -30.19 % ±1.89% ±2.51% ±3.27% n = [14e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=140000 *** -29.44 % ±1.78% ±2.37% ±3.08% util/inspect.js option='none' method='Date' n=140000 *** -34.54 % ±1.45% ±1.94% ±2.57% util/inspect.js option='showHidden' method='Date' n=140000 *** -29.27 % ±2.12% ±2.83% ±3.68%Refs: #50571