Skip to content

src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace() #50518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace() #50518

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb9c13
src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace()
joyeecheung Nov 2, 2023
708664b
fixup! src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktra…
joyeecheung Nov 3, 2023
7b506cd
fixup! fixup! src: use v8::Isolate::TryGetCurrent() in DumpJavaScript…
joyeecheung Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/debug_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ void DumpNativeBacktrace(FILE* fp) {
}

void DumpJavaScriptBacktrace(FILE* fp) {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Isolate* isolate = v8::Isolate::TryGetCurrent();
if (isolate == nullptr) {
return;
}
Expand Down
5 changes: 5 additions & 0 deletions test/cctest/test_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,3 +299,8 @@ TEST(UtilTest, SPrintF) {
const std::string with_zero = std::string("a") + '\0' + 'b';
EXPECT_EQ(SPrintF("%s", with_zero), with_zero);
}


TEST(UtilTest, DumpJavaScriptStackWithNoIsolate) {
node::DumpJavaScriptBacktrace(stderr);
}