Skip to content

fs: improve error performance for unlinkSync #49856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2023
Merged

fs: improve error performance for unlinkSync #49856

merged 2 commits into from
Sep 27, 2023

Conversation

CanadaHonk
Copy link
Member

@CanadaHonk CanadaHonk commented Sep 25, 2023 •
edited by anonrig
Loading

Results from i7 Windows laptop:

                                                  confidence improvement accuracy (*)    (**)   (***)
fs\bench-unlinkSync.js n=1000 type='existing'                     1.47 %       ±6.49%  ±8.64% ±11.25%
fs\bench-unlinkSync.js n=1000 type='non-existing'        ***     75.14 %      ±15.72% ±21.01% ±27.54%

Ref: nodejs/performance#106

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1414/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 25, 2023
@anonrig anonrig mentioned this pull request Sep 25, 2023
Open
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54216/

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. needs-benchmark-ci PR that need a benchmark CI run. labels Sep 25, 2023
@anonrig
Copy link
Member

anonrig commented Sep 25, 2023 •
edited by targos
Loading

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1414/

17:17:09                                                   confidence improvement accuracy (*)   (**)   (***)
17:17:09 fs/bench-unlinkSync.js n=1000 type='existing'                     2.75 %       ±4.00% ±5.34%  ±7.01%
17:17:09 fs/bench-unlinkSync.js n=1000 type='non-existing'        ***    100.74 %       ±7.23% ±9.70% ±12.79%

@anonrig anonrig added the performance Issues and PRs related to the performance of Node.js. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54228/

@github-actions github-actions bot mentioned this pull request Sep 27, 2023
Open
21 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7e0b6a5 into nodejs:main Sep 27, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 7e0b6a5

CanadaHonk added a commit to CanadaHonk/node that referenced this pull request Sep 27, 2023
@CanadaHonk
fs: improve error performance for unlinkSync
c43c941 
PR-URL: nodejs#49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Open
19 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@CanadaHonk @ruyadorno
fs: improve error performance for unlinkSync
e82e46c 
PR-URL: #49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@CanadaHonk @ruyadorno
fs: improve error performance for unlinkSync
6acf800 
PR-URL: #49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@CanadaHonk @alexfernandez
fs: improve error performance for unlinkSync
71f16a0 
PR-URL: nodejs#49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@CanadaHonk @debadree25
fs: improve error performance for unlinkSync
8bc06eb 
PR-URL: nodejs#49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CanadaHonk @nodejs-github-bot @anonrig @benjamingr