Skip to content

test: replace forEach with for..of in test-net-isipv4.js #49822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2023
Merged

test: replace forEach with for..of in test-net-isipv4.js #49822

merged 4 commits into from
Oct 21, 2023

Conversation

@niyashiyas
Copy link
Contributor

@niyashiyas niyashiyas commented Sep 23, 2023

test: Replaced forEach with for..of in test-net-isipv4.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
tniessen
tniessen reviewed Sep 23, 2023
View reviewed changes
test/parallel/test-net-isipv4.js Outdated
for(const ip of v4) {
assert.strictEqual(net.isIPv4(ip), true);
});
};
Copy link
Member

@tniessen tniessen Sep 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}

Copy link
Contributor Author

@niyashiyas niyashiyas Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made required changes.

@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
@niyashiyas
Copy link
Contributor Author

niyashiyas commented Sep 24, 2023

Please review again.

@niyashiyas niyashiyas changed the title test: Replaced forEach with for..of in test-net-isipv4.js test: replace forEach with for..of in test-net-isipv4.js Sep 30, 2023
lpinca
lpinca approved these changes Oct 9, 2023
View reviewed changes
@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54636/

This was referenced Oct 10, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54969/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55078/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit b084b26 into nodejs:main Oct 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 21, 2023

Landed in b084b26

targos pushed a commit that referenced this pull request Oct 23, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-net-isipv4.js
67c599e 
PR-URL: #49822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@niyashiyas @alexfernandez
test: replace forEach with for..of in test-net-isipv4.js
dd23de0 
PR-URL: nodejs#49822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-net-isipv4.js
379a725 
PR-URL: #49822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-net-isipv4.js
2f0ffde 
PR-URL: #49822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in test-net-isipv4.js
2273c9e 
PR-URL: nodejs/node#49822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in test-net-isipv4.js
4d0d987 
PR-URL: nodejs/node#49822
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@niyashiyas @nodejs-github-bot @lpinca @tniessen