Skip to content

[v18.x] lib,src,test: lint codebase according new rules #48697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[v18.x] lib,src,test: lint codebase according new rules #48697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0daa932
lib,src,test: lint codebase according new rules for v18.x
juanarbol Jul 7, 2023
35c1c81
tools: remove non-existing file from CODEOWNERS file
juanarbol Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@

# Permission Model
/doc/api/permissions.md @nodejs/security-wg
/lib/internal/process/permission.js @nodejs/security-wg
/src/permission/* @nodejs/security-wg

# Dependency Update Tools
Expand Down
8 changes: 0 additions & 8 deletions lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,6 @@ const {
JSTransferable, kDeserialize, kTransfer, kTransferList,
} = require('internal/worker/js_transferable');

const {
newReadableStreamFromStreamBase,
} = require('internal/webstreams/adapters');

const {
readableStreamCancel,
} = require('internal/webstreams/readablestream');

const getDirectoryEntriesPromise = promisify(getDirents);
const validateRmOptionsPromise = promisify(validateRmOptions);

Expand Down
1 change: 0 additions & 1 deletion lib/internal/modules/esm/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ class ESMLoader {
* until it reaches the bottom or short-circuits.
* @param {URL['href']} url The URL/path of the module to be loaded
* @param {object} context Metadata about the module
*
* @returns {{ format: ModuleFormat, source: ModuleSource }}
*/
async load(url, context = {}) {
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ ignore = [
"PLC1901",
"RUF005",
"RUF100",
"RUF012",
]
line-length = 172
target-version = "py37"
Expand Down
7 changes: 4 additions & 3 deletions src/node_builtins.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,10 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
return scope.Escape(fun);
}

MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
const char* id,
Environment* optional_env) {
MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
Local<Context> context,
const char* id,
Environment* optional_env) {
Result result;
std::vector<Local<String>> parameters;
Isolate* isolate = context->GetIsolate();
Expand Down
2 changes: 0 additions & 2 deletions test/common/wpt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,6 @@ class WPTRunner {
/**
* Report the status of each specific test case (there could be multiple
* in one test file).
*
* @param {string} filename
* @param {Test} test The Test object returned by WPT harness
*/
Expand All @@ -735,7 +734,6 @@ class WPTRunner {

/**
* Report the status of each WPT test (one per file)
*
* @param {string} filename
* @param {object} harnessStatus - The status object returned by WPT harness.
*/
Expand Down