util: Use primordials.ArrayPrototypeIndexOf instead of mutable method
#48586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Jun 28, 2023
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Thanks! Can you amend the commit message to comply with our guidelines? Something like util: use `primordials.ArrayPrototypeIndexOf` instead of mutable method
DaisyDogs07
changed the title
ArrayPrototypeIndexOf in identicalSequenceRangeArrayPrototypeIndexOf in identicalSequenceRange
DaisyDogs07
changed the title
ArrayPrototypeIndexOf in identicalSequenceRangeprimordials.ArrayPrototypeIndexOf in identicalSequenceRange
Contributor
Author
|
Sorry about that. First time making a pull request or anything for something big :/ |
DaisyDogs07
changed the title
primordials.ArrayPrototypeIndexOf in identicalSequenceRangeprimordials.ArrayPrototypeIndexOf instead of mutable method
Contributor
|
I can see you changed the PR title, but unfortunately that's not what's needed: you need to amend the commit message, and then force push to your PR branch. Please make sure to also follow this rule: node/doc/contributing/pull-requests.md Lines 166 to 167 in 260092e Let me know if you need help with that, I can do it for you if that's more convenient. |
Contributor
Author
|
Unfortunately im new to PRs and i dont know how to force push something. may i ask if you could do it for me? |
I believe you forgot to use the primordial `ArrayPrototypeIndexOf` in `identicalSequenceRange` i dont know if this was intentional but im fixing it anyway :p
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
Landed in 4a26e2d, thanks for the contribution 🎉 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48586 Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48586 Reviewed-By: Antoine du Hamel <[email protected]>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48586 Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #48586 Reviewed-By: Antoine du Hamel <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 12, 2023
PR-URL: #48586 Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
PR-URL: #48586 Reviewed-By: Antoine du Hamel <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2023
PR-URL: #48586 Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a part of
identicalSequenceRangethat uses a mutable methodChanged it to use the primordial instead