Skip to content

test: remove flaky designation for some tests #48575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

test: remove flaky designation for some tests #48575

wants to merge 2 commits into from

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Jun 27, 2023 •
edited
Loading

It has been a long time since the failures have been seen in CI and I cannot reproduce them locally running

python.exe tools/test.py -J --repeat=1000 test/parallel/test-timers-immediate-queue.js
python.exe tools/test.py -J --repeat=1000 test/parallel/test-crypto-keygen.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 27, 2023
@lpinca lpinca force-pushed the remove/flaky-designation branch from 6104e4d to bb7a2df Compare June 27, 2023 08:46
@lpinca lpinca force-pushed the remove/flaky-designation branch from bb7a2df to 70d7d12 Compare June 27, 2023 15:19
@lpinca lpinca changed the title test: remove test-timers-immediate-queue flaky designation test: remove flaky designation for some tests Jun 27, 2023
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jun 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52517/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52521/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52524/

This was referenced Jun 28, 2023
Open
Open
@Trott

This comment was marked as resolved.

Sign in to view
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2023
This was referenced Jun 29, 2023
Closed
Closed
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 29, 2023

Landed in 1683e60...893c000

nodejs-github-bot pushed a commit that referenced this pull request Jun 29, 2023
@lpinca @nodejs-github-bot
test: remove test-timers-immediate-queue flaky designation
300634d 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jun 29, 2023
@lpinca @nodejs-github-bot
test: remove test-crypto-keygen flaky designation
893c000 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@lpinca lpinca deleted the remove/flaky-designation branch June 29, 2023 10:35
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
Open
33 tasks
This was referenced Jul 1, 2023
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@lpinca @RafaelGSS
test: remove test-timers-immediate-queue flaky designation
75aa0a7 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@lpinca @RafaelGSS
test: remove test-crypto-keygen flaky designation
07eb310 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
Open
22 tasks
@StefanStojanovic
Copy link
Contributor

StefanStojanovic commented Jul 4, 2023

I've been going through some recent builds (after this landed) and I see that test-crypto-keygen failed in few of those runs:

@lpinca lpinca mentioned this pull request Jul 4, 2023
Merged
lpinca added a commit to lpinca/node that referenced this pull request Jul 4, 2023
@lpinca
Revert "test: remove test-crypto-keygen flaky designation"
7c7bb6a 
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
@github-actions github-actions bot mentioned this pull request Jul 5, 2023
Open
20 tasks
nodejs-github-bot pushed a commit that referenced this pull request Jul 5, 2023
@lpinca
Revert "test: remove test-crypto-keygen flaky designation"
08638b7 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
@lpinca @juanarbol
Revert "test: remove test-crypto-keygen flaky designation"
dfa0aee 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-timers-immediate-queue flaky designation
b84712f 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-crypto-keygen flaky designation
66ae94c 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
Revert "test: remove test-crypto-keygen flaky designation"
a94c283 
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
PR-URL: nodejs#48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-timers-immediate-queue flaky designation
4f80e28 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-crypto-keygen flaky designation
8d48b5f 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
Revert "test: remove test-crypto-keygen flaky designation"
f687d00 
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
PR-URL: nodejs#48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
test: remove test-timers-immediate-queue flaky designation
9308992 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
test: remove test-crypto-keygen flaky designation
87e5563 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
cfcb3de 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
test: remove test-timers-immediate-queue flaky designation
df9a9af 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
test: remove test-crypto-keygen flaky designation
dd1805e 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
0b62218 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
a79112b 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@aduh95 aduh95 mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lpinca @nodejs-github-bot @Trott @StefanStojanovic @anonrig @MoLow @VoltrexKeyva