Skip to content

url: do not use object as hashmap #47415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2023
Merged

url: do not use object as hashmap #47415

merged 2 commits into from
Apr 7, 2023

Conversation

@TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Apr 5, 2023

Fixes cases like new URLSearchParams({ hasOwnProperty: 1 }).

@TimothyGu
url: do not use object as hashmap
53b7cdd 
Fixes cases like new URLSearchParams({ hasOwnProperty: 1 }).
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 5, 2023 •
edited by TimothyGu
Loading

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 5, 2023
@TimothyGu TimothyGu requested a review from anonrig April 5, 2023 03:25
@TimothyGu TimothyGu added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 5, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50946/

mscdex
mscdex reviewed Apr 5, 2023
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 5, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50965/

@TimothyGu TimothyGu added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 5, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50982/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51018/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51025/

@TimothyGu TimothyGu added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Apr 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0c76922 into nodejs:main Apr 7, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2023

Landed in 0c76922

@TimothyGu TimothyGu deleted the url-map2 branch April 7, 2023 04:11
@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@TimothyGu @RafaelGSS
url: do not use object as hashmap
e727eb0 
Fixes cases like new URLSearchParams({ hasOwnProperty: 1 }).

PR-URL: #47415
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@TimothyGu @danielleadams
url: do not use object as hashmap
585e99b 
Fixes cases like new URLSearchParams({ hasOwnProperty: 1 }).

PR-URL: #47415
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@TimothyGu @MoLow
url: do not use object as hashmap
9a2354d 
Fixes cases like new URLSearchParams({ hasOwnProperty: 1 }).

PR-URL: nodejs#47415
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
@richardlau richardlau mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemire lemire lemire left review comments

@Trott Trott Trott left review comments

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

+1 more reviewer

@mscdex mscdex mscdex left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@TimothyGu @nodejs-github-bot @mscdex @lemire @Trott @benjamingr @lpinca @anonrig @targos