Skip to content

dns: expose getDefaultResultOrder #46973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2023
Merged

dns: expose getDefaultResultOrder #46973

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
382dcf1
dns: expose getDefaultResultOrder
btea Mar 6, 2023
d4304e2
docs: update doc
btea Mar 6, 2023
8f487c3
docs: add yaml
btea Mar 6, 2023
0c611c5
test: add test
btea Mar 7, 2023
6157c43
test: update test
btea Mar 8, 2023
e5343b5
Update doc/api/dns.md
btea Mar 8, 2023
7148776
test: update test
btea Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions doc/api/dns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,14 @@ priority than [`--dns-result-order`][]. When using [worker threads][],
[`dns.setDefaultResultOrder()`][] from the main thread won't affect the default
dns orders in workers.

## `dns.getDefaultResultOrder()`

<!-- YAML
added: REPLACEME
-->

Get the value of `dnsOrder`.

## `dns.setServers(servers)`

<!-- YAML
Expand Down Expand Up @@ -1351,6 +1359,14 @@ higher priority than [`--dns-result-order`][]. When using [worker threads][],
[`dnsPromises.setDefaultResultOrder()`][] from the main thread won't affect the
default dns orders in workers.

### `dnsPromises.getDefaultResultOrder()`

<!-- YAML
added: REPLACEME
-->

Get the value of `dnsOrder`.

### `dnsPromises.setServers(servers)`

<!-- YAML
Expand Down
2 changes: 2 additions & 0 deletions lib/dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const {
validateHints,
emitInvalidHostnameWarning,
getDefaultVerbatim,
getDefaultResultOrder,
setDefaultResultOrder,
errorCodes: dnsErrorCodes,
} = require('internal/dns/utils');
Expand Down Expand Up @@ -305,6 +306,7 @@ module.exports = {
lookupService,

Resolver,
getDefaultResultOrder,
setDefaultResultOrder,
setServers: defaultResolverSetServers,

Expand Down
2 changes: 2 additions & 0 deletions lib/internal/dns/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const {
emitInvalidHostnameWarning,
getDefaultVerbatim,
errorCodes: dnsErrorCodes,
getDefaultResultOrder,
setDefaultResultOrder,
setDefaultResolver,
} = require('internal/dns/utils');
Expand Down Expand Up @@ -335,6 +336,7 @@ module.exports = {
lookup,
lookupService,
Resolver,
getDefaultResultOrder,
setDefaultResultOrder,
setServers: defaultResolverSetServers,

Expand Down
5 changes: 5 additions & 0 deletions lib/internal/dns/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ function setDefaultResultOrder(value) {
dnsOrder = value;
}

function getDefaultResultOrder() {
return dnsOrder;
}

function createResolverClass(resolver) {
const resolveMap = { __proto__: null };

Expand Down Expand Up @@ -346,6 +350,7 @@ module.exports = {
validateTries,
emitInvalidHostnameWarning,
getDefaultVerbatim,
getDefaultResultOrder,
setDefaultResultOrder,
errorCodes,
createResolverClass,
Expand Down