Skip to content

inspector: log response and requests in the inspector for debugging #46941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023
Merged

inspector: log response and requests in the inspector for debugging #46941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54eb7bb
inspector: log response and requests in the inspector for debugging
joyeecheung Mar 3, 2023
5179c81
fixup! inspector: log response and requests in the inspector for debu…
joyeecheung Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,

void dispatchProtocolMessage(const StringView& message) {
std::string raw_message = protocol::StringUtil::StringViewToUtf8(message);
per_process::Debug(DebugCategory::INSPECTOR_SERVER,
"[inspector received] %s\n",
raw_message);
std::unique_ptr<protocol::DictionaryValue> value =
protocol::DictionaryValue::cast(protocol::StringUtil::parseMessage(
raw_message, false));
Expand Down Expand Up @@ -296,6 +299,13 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
void flushProtocolNotifications() override { }

void sendMessageToFrontend(const StringView& message) {
if (per_process::enabled_debug_list.enabled(
DebugCategory::INSPECTOR_SERVER)) {
std::string raw_message = protocol::StringUtil::StringViewToUtf8(message);
per_process::Debug(DebugCategory::INSPECTOR_SERVER,
"[inspector send] %s\n",
raw_message);
}
delegate_->SendMessageToFrontend(message);
}

Expand Down