src: share common code paths for SEA and embedder script #46825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since SEA is very similar in principle to embedding functionality, it makes sense to share code paths where possible. This commit does so and addresses a `TODO` while doing so. It also adds a utility to directly run CJS code to the embedder startup callback, which comes in handy for this purpose. Finally, this commit is breaking because it aligns the behavior of `require()`ing internal modules; previously, embedders could use the `require` function that they received to do so. (If this is not considered breaking because accessing internals is not covered by the API, then this would need ABI compatibility patches for becoming fully non-breaking.)
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
RaisinTen
reviewed
Feb 25, 2023
joyeecheung
reviewed
Feb 27, 2023
joyeecheung
reviewed
Feb 27, 2023
github-actions
bot
removed
the
request-ci
Collaborator
15 tasks
Collaborator
joyeecheung
approved these changes
Mar 1, 2023
addaleax
added
the
semver-major
Collaborator
15 tasks
jasnell
approved these changes
Mar 2, 2023
JungMinu
approved these changes
Mar 2, 2023
addaleax
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3803b02 |
This was referenced Mar 3, 2023
RaisinTen
added
the
single-executable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SEA is very similar in principle to embedding functionality, it makes sense to share code paths where possible. This commit does so and addresses a
TODOwhile doing so.It also adds a utility to directly run CJS code to the embedder startup callback, which comes in handy for this purpose.
Finally, this commit is breaking because it aligns the behavior of
require()ing internal modules; previously, embedders could use therequirefunction that they received to do so. (If this is not considered breaking because accessing internals is not covered by the API, then this would need ABI compatibility patches for becoming fully non-breaking.)