Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of nghttp2 to 1.52.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 22, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Feb 22, 2023
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Feb 23, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 24, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/46773
✔  Done loading data for nodejs/node/pull/46773
----------------------------------- PR info ------------------------------------
Title      deps: update nghttp2 to 1.52.0 (#46773)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-nghttp2 -> nodejs:main
Labels     http2, dependencies
Commits    1
 - deps: update nghttp2 to 1.52.0
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/46773
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46773
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 22 Feb 2023 14:54:48 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46773#pullrequestreview-1310173009
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/46773#pullrequestreview-1310511169
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-02-23T01:17:51Z: https://ci.nodejs.org/job/node-test-pull-request/49904/
- Querying data for job/node-test-pull-request/49904/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 46773
From https://github.com/nodejs/node
 * branch                  refs/pull/46773/merge -> FETCH_HEAD
✔  Fetched commits as 0c90be907211..195b49d2427a
--------------------------------------------------------------------------------
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch main
Your branch is up to date with 'origin/main'.

Cherry-pick currently in progress.
(run "git cherry-pick --continue" to continue)
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
(use "git add ..." to include in what will be committed)
labels.json
output

nothing added to commit but untracked files present (use "git add" to track)
✖ Failed to apply patches

https://github.com/nodejs/node/actions/runs/4263580508

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@marco-ippolito
Copy link
Member

it has already been updated to 1.52.0 by #46636, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants