Skip to content

src: per-realm binding data #46556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

src: per-realm binding data #46556

merged 1 commit into from
Feb 21, 2023

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Feb 8, 2023

Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.

@legendecas legendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm label Feb 8, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 8, 2023 •
edited by legendecas
Loading

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/startup
  • @nodejs/realm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 8, 2023
joyeecheung
joyeecheung approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2023
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/4123606552

@joyeecheung
Copy link
Member

joyeecheung commented Feb 8, 2023

CI is under security embargo until at least 14 Feb.

@legendecas
Copy link
Member Author

legendecas commented Feb 8, 2023

Yeah, let's wait for the security releases first.

mcollina
mcollina approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@legendecas legendecas mentioned this pull request Feb 9, 2023
Open
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 16, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49595/

@legendecas legendecas removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Feb 17, 2023
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Open
32 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49757/

@legendecas
Copy link
Member Author

legendecas commented Feb 20, 2023

Rebased on the tip of the main branch.

@legendecas legendecas added request-ci Add this label to start a Jenkins CI on a PR. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49786/

@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Open
26 tasks
@legendecas
src: per-realm binding data
7aadcd0 
Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023
mcollina
mcollina approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49845/

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Feb 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit ca07aba into nodejs:main Feb 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 21, 2023

Landed in ca07aba

@github-actions github-actions bot mentioned this pull request Feb 22, 2023
Open
34 tasks
@legendecas legendecas deleted the binding-data branch February 22, 2023 03:51
This was referenced Feb 22, 2023
Closed
Merged
@juanarbol
Copy link
Member

juanarbol commented Mar 1, 2023

Could you please backport this into v18.x?

targos pushed a commit that referenced this pull request Mar 13, 2023
@legendecas @targos
src: per-realm binding data
973287a 
Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.

PR-URL: #46556
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@legendecas legendecas mentioned this pull request Mar 20, 2023
Closed
legendecas added a commit to legendecas/node that referenced this pull request Mar 20, 2023
@legendecas
src: per-realm binding data
4740107 
Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.

PR-URL: nodejs#46556
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
# Conflicts:
#	src/dataqueue/queue.cc
legendecas added a commit to legendecas/node that referenced this pull request May 18, 2023
@legendecas
src: per-realm binding data
125af5c 
Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.

PR-URL: nodejs#46556
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
# Conflicts:
#	src/dataqueue/queue.cc
danielleadams pushed a commit that referenced this pull request May 29, 2023
@legendecas @danielleadams
src: per-realm binding data
0b92035 
Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.

PR-URL: #46556
Backport-PR-URL: #47174
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
# Conflicts:
#	src/dataqueue/queue.cc
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@legendecas @RafaelGSS
src: per-realm binding data
05f5c79 
Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.

PR-URL: nodejs#46556
Backport-PR-URL: nodejs#47174
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
# Conflicts:
#	src/dataqueue/queue.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. realm Issues and PRs related to the ShadowRealm API and node::Realm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@legendecas @nodejs-github-bot @joyeecheung @juanarbol @mcollina @cjihrig @aduh95