Skip to content

[v14.x backport] http2: fix memory leak when nghttp2 hd threshold is reached #45310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v14.x backport] http2: fix memory leak when nghttp2 hd threshold is reached #45310

wants to merge 2 commits into from

Conversation

@ywave620
Copy link
Contributor

@ywave620 ywave620 commented Nov 4, 2022 •
edited
Loading

Backport #41502 to v14
Address #45295

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2022

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. v14.x labels Nov 4, 2022
@ywave620
http2: fix memory leak on nghttp2 hd threshold
2291969 
PR-URL: nodejs#41502
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47692/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47705/

RafaelGSS
RafaelGSS approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ywave620
Copy link
Contributor Author

ywave620 commented Nov 14, 2022

@RafaelGSS Would you mind merging this?

@RafaelGSS
Copy link
Member

RafaelGSS commented Nov 14, 2022

@RafaelGSS Would you mind merging this?

The next releaser will merge it when performing the release. I believe the date will show up here nodejs/Release#567

@ywave620
Copy link
Contributor Author

ywave620 commented Nov 14, 2022

The next releaser will merge it when performing the release. I believe the date will show up here nodejs/Release#567

Okay. Thanks for the information :)

richardlau pushed a commit that referenced this pull request Nov 23, 2022
@ywave620 @richardlau
http2: fix memory leak when nghttp2 hd threshold is reached
c3a90c4 
Refs: #45295
PR-URL: #41502
Backport-PR-URL: #45310
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@richardlau
Copy link
Member

richardlau commented Nov 23, 2022

Landed in c3a90c4.

@richardlau richardlau closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ywave620 @nodejs-github-bot @RafaelGSS @richardlau @anonrig