Revert "deps: make V8 compilable with older glibc" #45162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84d455e.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
7 tasks
github-actions
bot
removed
the
request-ci
Collaborator
bnoordhuis
approved these changes
Oct 25, 2022
gengjiawen
approved these changes
Oct 25, 2022
targos
added
the
author ready
Collaborator
Collaborator
richardlau
approved these changes
Oct 25, 2022
BethGriggs
approved these changes
Oct 25, 2022
VoltrexKeyva
approved these changes
Oct 26, 2022
jasnell
approved these changes
Oct 26, 2022
lpinca
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 466d36e |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
This reverts commit 84d455e. PR-URL: #45162 Refs: #45118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
This reverts commit 84d455e. PR-URL: #45162 Refs: #45118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 84d455e.
Refs: #45118