Skip to content

doc: be more definite and present tense-y #45120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2022
Merged

doc: be more definite and present tense-y #45120

merged 1 commit into from
Oct 23, 2022

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Oct 22, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Oct 22, 2022
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2022
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022

Fast-track has been requested by @jasnell. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit 89c4e1f into nodejs:main Oct 23, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 23, 2022

Landed in 89c4e1f

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@bnoordhuis @RafaelGSS
doc: be more definite and present tense-y
2629fc2 
PR-URL: #45120
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@bnoordhuis @RafaelGSS
doc: be more definite and present tense-y
c23e023 
PR-URL: #45120
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis @danielleadams
doc: be more definite and present tense-y
34aea8c 
PR-URL: #45120
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis @danielleadams
doc: be more definite and present tense-y
24e084a 
PR-URL: #45120
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@bnoordhuis @danielleadams
doc: be more definite and present tense-y
3ddb6cc 
PR-URL: #45120
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@santigimeno santigimeno santigimeno approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.