Skip to content

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Sep 29, 2022

this backport PR includes
#44520
#44592
#44620

to be merged after / on top of #44815

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 29, 2022
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from 1cffc6c to 9fbebd2 Compare September 29, 2022 08:54
@MoLow
Copy link
Member Author

MoLow commented Sep 29, 2022

CC @nodejs/releasers

MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from 9fbebd2 to c743751 Compare September 29, 2022 09:04
@MoLow MoLow changed the title [v18.x backport] test_runner: support using --inspect with --test [v18.x backport] test_runner: support using --inspect with --test Sep 29, 2022
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from c743751 to 37d1e5a Compare September 29, 2022 13:58
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

MoLow added 3 commits October 2, 2022 13:49
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from 37d1e5a to a797681 Compare October 2, 2022 10:50
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@MoLow
Copy link
Member Author

MoLow commented Oct 3, 2022

CC @danielleadams

@MoLow MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 3, 2022
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
PR-URL: #44520
Backport-PR-URL: #44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
PR-URL: #44592
Backport-PR-URL: #44813
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
PR-URL: #44620
Backport-PR-URL: #44813
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams
Copy link
Contributor

Landed in 36227ed...56c9c98

@MoLow MoLow deleted the backport-test-runner-inspect branch October 12, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants