Skip to content

doc: deprecate coercion to integer in process.exitCode #44712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: deprecate coercion to integer in process.exitCode #44712

wants to merge 1 commit into from

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Sep 18, 2022

This warns of invalid uses of process.exitCode (such as mentioned in #43716 (comment)).

In a quick search for process.exitCode below, I can't find invalid uses.
However, I open this PR since it may need the doc-only deprecation first instead of throwing a validation error.

Refs: #43716
Refs: #43738

Signed-off-by: Daeyeon Jeong [email protected]

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Sep 18, 2022
aduh95
aduh95 reviewed Sep 18, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to bundle this with DEP0164 as it is arguably the same thing.

@daeyeon
Copy link
Member Author

daeyeon commented Sep 18, 2022

A deprecation warning for process.exitCode is also added to #44711. Closing this PR for now.

@daeyeon daeyeon closed this Sep 18, 2022
@aduh95
Copy link
Contributor

aduh95 commented Sep 18, 2022

I mean, we could still update the docs to clarify that both process.exit and process.exitCode are subject to the deprecation.