bootstrap: generate bootstrapper arguments in BuiltinLoader #44488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
reviewed
Sep 5, 2022
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
The change LGTM, but the linter is complaining...
joyeecheung
force-pushed
the
compile-arg
branch
from
3ad93cc to
a4c8645
Compare
Member
Author
|
Rebased and fixed the linter error. |
Collaborator
joyeecheung
force-pushed
the
compile-arg
branch
from
a4c8645 to
501fee7
Compare
Collaborator
Collaborator
legendecas
approved these changes
Sep 6, 2022
15 tasks
This was referenced Sep 8, 2022
Collaborator
Collaborator
30 tasks
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7850802 |
28 tasks
29 tasks
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
PR-URL: nodejs#44488 Reviewed-By: Chengzhong Wu <[email protected]>
23 tasks
Member
|
Hi @joyeecheung. This commit didn't land cleanly on v18.x. Could you please backport? |
Member
|
The builtins thing did not land well in the v16.x release line (#44135); marking this as backport-blocked for the v16.x branch. |
targos
pushed a commit
that referenced
this pull request
Oct 29, 2023
PR-URL: #44488 Reviewed-By: Chengzhong Wu <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#44488 Reviewed-By: Chengzhong Wu <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#44488 Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit comes from #44472