doc: improve test runner timeout docs #43836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a warning to clarify that it is not a reliable mechanism for cancelling tests. Fix the default value of the timeout option. Simplify and capitalize the YAML description field.
tniessen
added
the
test_runner
nodejs-github-bot
added
doc
|
cc @nodejs/test_runner @MoLow |
aduh95
approved these changes
Jul 14, 2022
tniessen
added
the
author ready
Co-authored-by: Antoine du Hamel <[email protected]>
F3n67u
added
the
commit-queue-squash
F3n67u
approved these changes
Jul 16, 2022
MoLow
approved these changes
Jul 17, 2022
F3n67u
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43836 ✔ Done loading data for nodejs/node/pull/43836 ----------------------------------- PR info ------------------------------------ Title doc: improve test runner timeout docs (#43836) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-test-runner-timeout-fixes-and-warning -> nodejs:main Labels doc, test, author ready, commit-queue-squash, test_runner Commits 2 - doc: improve test runner timeout docs - Apply suggestions from code review Committers 2 - Tobias Nießen - GitHub PR-URL: https://github.com/nodejs/node/pull/43836 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43836 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 14 Jul 2022 22:27:00 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43836#pullrequestreview-1039649792 ✖ This PR needs to wait 110 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2684745441 |
cjihrig
approved these changes
Jul 20, 2022
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 545ecc5 |
aduh95
pushed a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 20, 2022
Add a warning to clarify that it is not a reliable mechanism for cancelling tests. Fix the default value of the timeout option. Simplify and capitalize the YAML description field. PR-URL: nodejs/node#43836 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> (cherry picked from commit 545ecc57360fad50c49c81b56ae25fcc99d38456)
Add a warning to clarify that it is not a reliable mechanism for
cancelling tests.
Fix the default value of the timeout option.
Simplify and capitalize the YAML description field.